[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] locking down struct size/layout in remote-protocol.x



On 05/10/2010 02:36 PM, Jim Meyering wrote:
> Eric Blake wrote:
>> On 05/07/2010 03:23 PM, Jim Meyering wrote:
>>> +remote_protocol-structs:
>>> +	$(AM_V_GEN)if pdwtags --help > /dev/null 2>&1; then		\
>>
>> Some shells (at least Solaris /bin/sh) are noisy in spite of the
>> redirections, when a program doesn't exist.  I'm proposing a followup
>> patch to clean up this invocation to use a subshell, and also to fix the
>> subshell for cppi in cfg.mk.
> 
> Or you could consider the noise a two-pronged feature:
>   - notify user that their $(SHELL) is inferior
>   - more noise about lack of a useful developer tool (pdwtags or cppi)

In which case, your pdwtags usage is fine, and I should modify my patch
to just drop the cppi subshell altogether?

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]