[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: correct PATH in new test, for when running manually



Eric Blake wrote:
> On 05/11/2010 09:45 AM, Jim Meyering wrote:
>> I'd prepended a *file* to PATH, not the containing directory.
>> The bug would have shown up only when running this test manually.
>>
>>
>> -# If $abs_top_builddir/tools/virsh is not early in $PATH, put it there,
>> +# If $abs_top_builddir/tools is not early in $PATH, put it there,
>>  # so that we can safely invoke "virsh" simply with its name.
>>  case $PATH in
>> -  $abs_top_builddir/tools/src:$abs_top_builddir/tools/virsh:*) ;;
>> -  $abs_top_builddir/tools/virsh:*) ;;
>> -  *) PATH=$abs_top_builddir/tools/virsh:$PATH; export PATH ;;
>> +  $abs_top_builddir/tools/src:$abs_top_builddir/tools:*) ;;
>> +  $abs_top_builddir/tools:*) ;;
>> +  *) PATH=$abs_top_builddir/tools:$PATH; export PATH ;;
>
> ACK.

Thanks. Pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]