[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] build: update gnulib



On 05/11/2010 09:53 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> * .gnulib: Update to latest.
>> * src/esx/esx_util.c (AI_ADDRCONFIG): Rely on gnulib.
>> * src/remote/remote_driver.c (AI_ADDRCONFIG): Likewise.
>> * tools/virsh.c (WEXITSTATUS, O_SYNC): Likewise.
> ...
>> diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c
> ...
>> -/* AI_ADDRCONFIG is missing on some systems. */
>> -#ifndef AI_ADDRCONFIG
>> -# define AI_ADDRCONFIG 0
>> -#endif
> 
> All looks fine, except the above.
> You can remove a definition only if the gnulib module that provides
> the definition is being used.  That's provided by the netdb
> module, and libvirt isn't using it (yet).
> 
> So just add netdb to the list in bootstrap.conf, and consider
> this ACK'd.

Thanks, applied with that correction (after re-testing with 'make check').

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]