[libvirt] [PATCH] node_device: udev: Fix PCI product/vendor swappage
Cole Robinson
crobinso at redhat.com
Tue May 11 20:57:05 UTC 2010
On 05/11/2010 04:44 PM, Dave Allan wrote:
> On Tue, May 11, 2010 at 02:48:03PM -0400, Cole Robinson wrote:
>> Product and vendor values were swapped in the XML, which made virt-manager
>> PCI device listing kinda useless.
>>
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> ---
>> src/node_device/node_device_udev.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
>> index bcfe991..4a9d65f 100644
>> --- a/src/node_device/node_device_udev.c
>> +++ b/src/node_device/node_device_udev.c
>> @@ -382,8 +382,8 @@ static int udevTranslatePCIIds(unsigned int vendor,
>>
>> /* pci_get_strings returns void */
>> pci_get_strings(&m,
>> - &vendor_name,
>> &device_name,
>> + &vendor_name,
>> NULL,
>> NULL);
>>
>> --
>> 1.6.6.1
>>
>> --
>
> ACK, confirmed that the problem exists and that the patch fixes it.
>
> Dave
Thanks, pushed now.
- Cole
More information about the libvir-list
mailing list