[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix NULL dereference in remoteDomainMigratePrepare2



On 05/12/2010 08:53 AM, jdenemar redhat com wrote:
> From: Jiri Denemark <jdenemar redhat com>
> 
> ---
>  src/remote/remote_driver.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 990bfce..c62e3d6 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -2849,8 +2849,12 @@ remoteDomainMigratePrepare2 (virConnectPtr dconn,
>          goto done;
>  
>      if (ret.cookie.cookie_len > 0) {
> -        *cookie = ret.cookie.cookie_val; /* Caller frees. */
> -        *cookielen = ret.cookie.cookie_len;
> +        if (cookie && cookielen) {
> +            *cookie = ret.cookie.cookie_val; /* Caller frees. */
> +            *cookielen = ret.cookie.cookie_len;
> +        } else {
> +            VIR_FREE(ret.cookie.cookie_val);
> +        }

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]