[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix cygwin build



On 05/14/2010 04:05 PM, Eric Blake wrote:
> make[3]: *** No rule to make target `-lxml2', needed by `libvirt.la'.  Stop.
> 
> Due to treating the wrong string as a dependency.
> 
> * src/Makefile.am (libvirt_la_DEPENDENCIES): Depend only on
> locally-built file, not on strings that might resolve as '-lxml2'.

Aargh.  This fixed incremental builds for cygwin, but broke fresh builds
everywhere.  Followup patch coming soon, to unbreak the build.

>  libvirt_la_LIBADD += $(LIBXML_LIBS) \
>                      $(LIBPCAP_LIBS) \
>  		    $(DRIVER_MODULE_LIBS) \
>  		    $(CYGWIN_EXTRA_LIBADD) ../gnulib/lib/libgnu.la
>  libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) -DIN_LIBVIRT
> -libvirt_la_DEPENDENCIES = $(libvirt_la_LIBADD) $(LIBVIRT_SYMBOL_FILE)
> +libvirt_la_DEPENDENCIES = ../gnulib/lib/libgnu.la $(LIBVIRT_SYMBOL_FILE)

$(DRIVER_MODULE_LIBS) is important, after all.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]