[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix cygwin build, correctly this time



On 05/17/2010 11:59 AM, Stefan Berger wrote:
> On Mon, 2010-05-17 at 10:49 -0600, Eric Blake wrote:
>> On 05/17/2010 07:20 AM, Stefan Berger wrote:
>>> On Fri, 2010-05-14 at 18:32 -0600, Eric Blake wrote:
>>>> Fix the cygwin regression introduced in commit 48445ccff, but
>>>> without repeating the fresh build regression of commit
>>>> 2d550542e.

And since both of those regressions were mine, my apologies for the time
this has been broken.

>>>>
>>>>  noinst_LTLIBRARIES = libvirt_util.la
>>>> -libvirt_la_LIBADD = libvirt_util.la
>>>> +libvirt_la_LIBADD = $(libvirt_la_BUILT_LIBADD)
>>>> +libvirt_la_BUILT_LIBADD = libvirt_util.la
>>>>  libvirt_util_la_SOURCES =					\
>>>>  		$(UTIL_SOURCES)
>>>
>>> I tried to apply it but the indentation of above line doesn't make it
>>> fit (on my machine the $ is under the 'S'). Hunks 1,2,22 fail for me and
>>> many others have fuzz 1.
>>
>> The same patch can be grabbed from here:
>>
>> git pull git://repo.or.cz/libvirt/ericb.git libadd-fix
>>
> 
> It didn't build before, now that I pull from there it does -> ACK.

Thanks for the review.  Pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]