[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] tests: Skip daemon-conf test if dir exceeds UNIX_PATH_MAX



On 05/17/2010 02:32 PM, Eric Blake wrote:
> On 05/17/2010 12:21 PM, Cole Robinson wrote:
>> +++ b/tests/daemon-conf
>> @@ -76,6 +76,13 @@ sed 's,^log_outputs.*,log_outputs="3:file:'"$(pwd)/log"'",' tmp.conf > k \
>>      || fail=1
>>  mv k tmp.conf || fail=1
>>  
>> +# Unix socket max path size is 108 on linux. If the generated sock path
>> +# exceeds this, the test will fail, so skip it if CWD is too long
>> +SOCKPATH=`pwd`/libvirt-sock
>> +if test 108 -lt `echo $SOCKPATH | wc -c`; then
>> +    skip_test_ "CWD too long"
>> +fi
> 
> Makes for a smaller diff with the early exit :)
> 
> ACK.
> 

Thanks, pushed.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]