[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Clarify a couple error messages



On 05/17/2010 01:38 PM, Cole Robinson wrote:
> A fedora translator filed:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=580816
> 
> Pointing out these two error messages as unclear: "write save" sounds
> like a typo without context, and lack of a colon made the second message
> difficult to parse.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/qemu/qemu_driver.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 582fdee..9ae8307 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -4805,7 +4805,8 @@ static int qemudDomainSaveFileOpHook(int fd, void *data) {
>      if (safewrite(fd, hdata->header, sizeof(*hdata->header)) != sizeof(*hdata->header)) {
>          ret = errno;
>          qemuReportError(VIR_ERR_OPERATION_FAILED,
> -                         _("failed to write save header to '%s'"), hdata->path);
> +                        _("failed to write domain save file header to '%s'"),

Four consecutive nouns isn't much easier to parse.  What about:

failed to write header to domain save file '%s'

>              if (statfs_ret == -1) {
>                  virReportSystemError(errno,
> -                                     _("Failed to create domain save file '%s'"
> -                                       " statfs of all elements of path failed."),
> +                                     _("Failed to create domain save file "
> +                                       "'%s': statfs of all elements of path "
> +                                       "failed"),

This one's good (and nice that you nuked the trailing '.')

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]