[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virFileResolveLink: fix return value



On 05/17/2010 01:49 PM, Chris Lalancette wrote:
> On 05/14/2010 04:59 PM, Eric Blake wrote:
>> virFileResolveLink was returning a positive value on error,
>> thus confusing callers that assumed failure was < 0.  The
>> confusion is further evidenced by callers that would have
>> ended up calling virReportSystemError with a negative value
>> instead of a valid errno.
>>
>> Fixes Red Hat BZ #591363.
>>
>> * src/util/util.c (virFileResolveLink): Live up to documentation.
>> * src/qemu/qemu_security_dac.c
>> (qemuSecurityDACRestoreSecurityFileLabel): Adjust callers.
>> * src/security/security_selinux.c
>> (SELinuxRestoreSecurityFileLabel): Likewise.
>> * src/storage/storage_backend_disk.c
>> (virStorageBackendDiskDeleteVol): Likewise.
> 
> Yep, makes lots of sense.
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]