[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] qemu: Remove explicit VNC XML cleanup



On 05/17/2010 11:17 AM, Cole Robinson wrote:
> This only exists for a certain cleanup path in StartVMDaemon, but is
> unneeded since domain_conf.c handles this for us automatically.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/qemu/qemu_driver.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 80f96b7..61aacfb 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -3581,10 +3581,6 @@ cleanup:
>          driver->securityDriver->domainReleaseSecurityLabel)
>          driver->securityDriver->domainReleaseSecurityLabel(vm);
>      qemuRemoveCgroup(driver, vm, 1);
> -    if ((vm->def->ngraphics == 1) &&
> -        vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
> -        vm->def->graphics[0]->data.vnc.autoport)
> -        vm->def->graphics[0]->data.vnc.port = -1;
>      if (logfile != -1)
>          close(logfile);
>      vm->def->id = -1;

ACK, after I read virDomainGraphicsDefParseXML to verify your claim.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]