[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] maint: avoid unwanted newline at end of diagnostic



Jiri Denemark wrote:
...
>> Subject: [PATCH 1/2] maint: remove unwanted newline at end of diagnostic
>>
>> * src/xen/xend_internal.c (xenDaemonDomainDefineXML): Remove \n.
>> * src/network/bridge_driver.c (networkAddMasqueradingIptablesRules):
>> Likewise.
>
>> From 532672f3a0c53213609dab49df2e7efcaf0eb594 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <meyering redhat com>
>> Date: Thu, 20 May 2010 11:13:41 +0200
>> Subject: [PATCH 2/2] maint: prohibit newline at end of diagnostic
>>
>> * cfg.mk (sc_prohibit_newline_at_end_of_diagnostic): New rule.
>> Idea proposed by Jiri Denemark.
>
> ACK to both patches.
>
> While the syntax check implementation is not perfect, it's good enough for now
> and can be enhanced if there is a desperate need for that.

Thanks.
Pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]