[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Refactor qemudDomainRestore



On 05/20/2010 08:54 AM, Jiri Denemark wrote:
> We need to be able to restore a domain which we already locked and
> started a job for it without undoing these steps. This patch factors
> out internals of qemudDomainRestore into separate functions which work
> for locked objects.
> ---
>  src/qemu/qemu_driver.c |  213 ++++++++++++++++++++++++++++++------------------
>  1 files changed, 135 insertions(+), 78 deletions(-)
> 

ACK to the change, but I'd recommend s/Image/SaveImage/g in the function
names: Image is too generic, at first glance I think 'disk image'.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]