[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirtd: mark strings for translation, including --help output



On 05/20/2010 01:42 PM, Jim Meyering wrote:
>>
>> Should we also do a followup that passes argv[0] to this method, so that
>> the error message can start with the program name?
> 
> Might as well.
> patch below.

Didn't see any signature change to daemonForkIntoBackground...

>> Missed a string.  This should be _("(disabled in ./configure)").
> 
> Thanks.  Fixed in the v2 below.

Confirmed.

> 
>>>          default:
>>> -            fprintf (stderr, "libvirtd: internal error: unknown flag: %c\n",
>>> +            fprintf (stderr, _("libvirtd: internal error: unknown flag: %c\n"),
>>
>> And here, should we be using %s/argv[0] instead of hard-coding the name
>> "libvirtd"?
> 
> Yes.

ACK to 1/2, but let's respin 2/2 to tweak daemonForkIntoBackground to
take another parameter...

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]