[libvirt] [PATCH v4] dots should be valid characters in interface names

[Charles Duffy]

On 05/20/2010 09:12 AM, Chris Lalancette wrote:
> On 05/20/2010 01:06 AM, Charles Duffy wrote:
>> On 05/19/2010 11:54 PM, Charles Duffy wrote:
>>> A revised patch is attached. This lifts its logic from its kernel
>>> counterpart, and is updated only to permit forward slashes (which, while
>>> disallowed for interface names with the kernel, are required for
>>> *device* names -- for which the ESX driver happens to overload this
>>> field. Ugh).
>
> Hm.  You know, I'm wondering if we should have "isValidIfname" at all in
> domain_conf.c.  The thing is that if you think about different platforms
> that this could be running on (Windows, Linux, Solaris, etc), and the
> number of different drivers that go through here (Qemu, Xen, ESX, Virtualbox,
> Phyp, openvz, ONE, UML), it seems like we have to allow everything to
> cover all bases.  Indeed, there is very little else in domain_conf.c that
> does validity checking, probably for just this reason.
>
> Charles, Laine, what do you think about just removing this check completely?

WORKSFORME as well.

I'm presuming that it's still appropriate to check against an empty 
string. Does the attached look right? If so, I'll update the associated 
RHEL6 ticket [https://bugzilla.redhat.com/show_bug.cgi?id=593907] 
appropriately.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-allow_dots_in_ifnames-r4.patch
Type: text/x-patch
Size: 1583 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100520/76a6346d/attachment-0001.bin>