[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove isValidIfname.



On 05/20/2010 05:30 PM, Eric Blake wrote:
> On 05/20/2010 01:57 PM, Chris Lalancette wrote:
>> We shouldn't be checking validity in domain_conf, since
>> it can be used by multiple different hosts and hypervisors.
>> Remove the check completely.
>>
>>  
>> -static bool
>> -isValidIfname(const char *ifname) {
>> -    return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;
>> -}
> 
> Conditional ACK - you also need to nuke the (now unused) definition of
> VALID_IFNAME_CHARS in domain_conf.h before pushing.
> 

Yeah, true.  I've pushed a combination of my and Charles Duffy's patch.
Thanks for the review.

Charles, could you give the head of the libvirt tree another test just
to make sure this works for your use-case?  Thanks.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]