[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove dead code after refactoring qemudDomainStart



On 05/21/2010 05:47 AM, Jiri Denemark wrote:
> The event is already generated and sent by qemudDomainObjStart, no need
> to do anything about here.
> ---
>  src/qemu/qemu_driver.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 2f644c9..5c8ab38 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -6630,7 +6630,6 @@ static int qemudDomainStart(virDomainPtr dom) {
>      struct qemud_driver *driver = dom->conn->privateData;
>      virDomainObjPtr vm;
>      int ret = -1;
> -    virDomainEventPtr event = NULL;
>  
>      qemuDriverLock(driver);
>      vm = virDomainFindByUUID(&driver->domains, dom->uuid);
> @@ -6661,8 +6660,6 @@ endjob:
>  cleanup:
>      if (vm)
>          virDomainObjUnlock(vm);
> -    if (event)
> -        qemuDomainEventQueue(driver, event);
>      qemuDriverUnlock(driver);
>      return ret;
>  }

ACK


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]