[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: force init scripts to rebuild on changed --prefix



2010/5/21 Eric Blake <eblake redhat com>:
> Otherwise, './configure --prefix=/foo && make &&
>  ./configure --prefix=/bar && make' leaves the wrong files
> in libvirtd.init (/foo instead of /bar).
>
> * daemon/Makefile.am (libvirtd.init): Add dependency on
> config.status.  Reported by Cole Robinson.
> ---
>
> Thanks for the simple recipe for testing; and I was correct that
> the fix was relatively simple (assuming, of course, that you
> consider autotools knowledge simple :)
>
>  daemon/Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/daemon/Makefile.am b/daemon/Makefile.am
> index 6f668ea..2f25c9d 100644
> --- a/daemon/Makefile.am
> +++ b/daemon/Makefile.am
> @@ -239,7 +239,7 @@ uninstall-init:
>
>  BUILT_SOURCES += libvirtd.init libvirt-guests.init
>
> -%.init: %.init.in
> +%.init: %.init.in $(top_srcdir)/config.status
>        $(AM_V_GEN)sed                                  \
>            -e s!\ localstatedir\@! localstatedir@!g    \
>            -e s!\ sbindir\@! sbindir@!g                \
> --
> 1.7.0.1
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]