[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Add host UUID (to libvirt capabilities)



On 05/24/2010 07:56 AM, Stefan Berger wrote:
> This patch adds the host UUID (to the capabilities of libvirt). The user
> may provide it in libvirtd.conf overriding whatever sysfs may
> return. If none or no valid UUID is provided in libvirtd.conf, reading the
> UUID from sysfs is attempted. If that function doesn't provide a valid 
> (not all digits may be equal), generate a temporary one.

If no UUID is provided in libvirtd.conf, it makes sense to try anything
for a fallback.  But if the user provided one, I'm a bit leery about
going behind their back and picking a different value if we think it was
invalid; I'd rather see libvirtd fail to start if we think the
user-specified UUID is invalid.  I'm just not sure of the impact if
someone has lots of host machines, and tries to copy libvirtd.conf
between them, without remembering to set correct uuids.

I haven't yet looked through this patch, but based on other comments, it
looks like you may be posting a v3 for review anyway.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]