[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: mpath: Fix incorrect VIR_ERROR use



On 05/24/2010 12:52 PM, Cole Robinson wrote:
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/storage/storage_backend_mpath.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/storage/storage_backend_mpath.c b/src/storage/storage_backend_mpath.c
> index 8d0a92a..3a137eb 100644
> --- a/src/storage/storage_backend_mpath.c
> +++ b/src/storage/storage_backend_mpath.c
> @@ -302,7 +302,7 @@ virStorageBackendMpathRefreshPool(virConnectPtr conn ATTRIBUTE_UNUSED,
>  {
>      int retval = 0;
>  
> -    VIR_ERROR(_("in %s"), __func__);
> +    VIR_DEBUG("in %s", __func__);

ACK.

Hmm, that reminds me, I have a pending series that asked whether we
wanted a global search-and-replace of the gcc-specific __FUNCTION__ to
the C99 __func__ (right now, internal.h guarantees the gcc spelling even
for other compilers).  Someday I'll get around to revisiting that series
(it's not the highest priority).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]