[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxcSetSchedulerParameters: reverse order of tests; improve a diagnostic



Eric Blake wrote:
> On 05/12/2010 07:23 PM, Eric Blake wrote:
>
> [trying to clear out some old mail]
>
>>> >From bc3404d9f12c42cf883a43395fee6fc14c952b2c Mon Sep 17 00:00:00 2001
>>> From: Jim Meyering <meyering redhat com>
>>> Date: Tue, 11 May 2010 15:43:32 +0200
>>> Subject: [PATCH] lxcSetSchedulerParameters: reverse order of tests; diagnose a failure
>>>
>>> * src/lxc/lxc_driver.c (lxcSetSchedulerParameters): Ensure that
>>> "->field" is "cpu_shares" before possibly giving a diagnostic about
>>> a type for a "cpu_shares" value.
>>> Also, virCgroupSetCpuShares could fail without evoking a diagnostic.
>>> Add one.
>
>>>              lxcError(VIR_ERR_INVALID_ARG, "%s",
>>> -                     _("Invalid type for cpu_shares tunable, expected a 'ullong'"));
>>> +                 _("Invalid type for cpu_shares tunable, expected a 'ullong'"));
>>
>> Why the indentation change here?
>
> To answer my own question - to fit in 80 columns.
>
>>
>> ACK.
>
> I applied this one on Jim's behalf, after validating that everything
> still builds fine after rebasing on current sources.

Thanks!  It'd fallen off my radar.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]