[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix failing virGetHostname.



On 05/24/2010 04:50 PM, Cole Robinson wrote:
> My bad, I figured dconn had the same URI on the dest host as it did on
> the source host. ACK to this patch then.
> 
> Maybe for the future we should consider always building a manual migrate
> URI in virsh.c (or maybe libvirt.c), using the destination connection
> URI hostname. This is what we do in virt-manager, since it's really it
> gives the closest guarantee for success.

Yeah, to be perfectly frank, the fact that the destination of the migration
tells us the hostname to migrate to is actually a design bug in the live
migration protocol.  I tried to do something like you suggest, but I
couldn't come up with a way that would support both old and new clients
and servers and not be qemu-specific.  For now, I think this is the best
we can do.  I think the correct answer in the medium to long term is to
make tunnelled migration the default, since we are already certain that
the libvirt control channel works.

-- 
Chris Lalancette


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]