[libvirt] [PATCH] Fix up basic migration.
Chris Lalancette
clalance at redhat.com
Tue May 25 14:55:31 UTC 2010
On 05/25/2010 10:52 AM, Matthias Bolte wrote:
> Well, the actual question is why does qemudDomainMigrate take an
> unsigned long? If it's because it should be able to take more then 32
> flags then unsigned long is the wrong type obviously, because unsigned
> long is just 32 bit width on 32 bit platforms. For that case
> qemudDomainMigrate has to have an unsigned long long flags parameter.
> If qemudDomainMigrate doesn't need to support more than 32 flags then
> lets just change unsigned long to unsigned int there.
I don't really think it needs to support more than 32 flags. However,
I don't think we can change it; on 64-bit, sizeof(unsigned long) == 8
while sizeof(unsigned int) == 4.
--
Chris Lalancette
More information about the libvir-list
mailing list