[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [v5 PATCH] add 802.1Qbh handling for port-profiles based on Stefan's previous patches



On 5/25/10 8:30 AM, "Stefan Berger" <stefanb us ibm com> wrote:

>>> +            usleep(125000);
>> 
>> Magic constant?
>> How did you determine this number?
>> How often are we expected to hit it?
>> Please add a comment.
> 
> This *may* be something I suggested -- to wait for 1/8 sec. Not sure
> whether this is
> too much, or not fast enough, but more like a shot into the 'blue'.

Yes, 1/8sec was something you mentioned earlier and it turns out to be a
good choice.  In my testing the loop makes on average 4 or 5 passes.  Some
times it only take one pass, other (rare) times it can take many more
passes.

> I'll post v7 addressing the comments.

I'll retest w/ v7 when it's ready.

-scott


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]