[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v7] add 802.1Qbh and 802.1Qbg handling



Stefan Berger wrote:
> This patch builds on the work recently posted by Stefan Berger.  It builds
> on top of Stefan's three posted patches:

Not a show-stopper, but your patch is corrupted due to split lines.
If you tell your mail client not to do that, it'll be easier
on folks who end up applying your patch.  Also, we prefer it when
contributors post git format-patch output or post via git send-email.

The first split line happened with this added line:

AC_DEFINE_UNQUOTED([WITH_VIRTUALPORT], $val, [whether vsi vepa support is enabled])

it's longer than 80, too, which we prefer to avoid.
Better to write it like this:

AC_DEFINE_UNQUOTED([WITH_VIRTUALPORT], $val,
  [whether vsi vepa support is enabled])

Hmm..  even after fixing two split lines,
I'm getting lots of failed hunks and at least one more split line:

  $ patch -p1 < j
  patching file configure.ac
  Hunk #1 FAILED at 2005.
  1 out of 1 hunk FAILED -- saving rejects to file configure.ac.rej
  patching file src/qemu/qemu_conf.c
  Hunk #1 FAILED at 1509.
  1 out of 1 hunk FAILED -- saving rejects to file src/qemu/qemu_conf.c.rej
  patching file src/qemu/qemu_driver.c
  Hunk #1 FAILED at 3709.
  Hunk #2 FAILED at 8514.
  2 out of 2 hunks FAILED -- saving rejects to file src/qemu/qemu_driver.c.rej
  patching file src/util/macvtap.c
  Hunk #2 succeeded at 41 with fuzz 1.
  Hunk #3 succeeded at 49 (offset -1 lines).
  patch: **** malformed patch at line 210: virtPort,

I'll try to straighten this out and repost shortly.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]