[libvirt] xen-proxy build broken

Matthias Bolte matthias.bolte at googlemail.com
Wed May 26 10:32:08 UTC 2010


2010/5/26 Eric Blake <eblake at redhat.com>:
> Didn't have time to fix this today; virVirtualPortProfileFormat is
> conditionally implemented based on PROXY, but unconditionally called.
> Throwing it out there in case someone else wants to beat me to the fix.
>
> cc1: warnings being treated as errors
> ../src/conf/domain_conf.c: In function 'virDomainNetDefFormat':
> ../src/conf/domain_conf.c:5343: error: implicit declaration of function
> 'virVirtualPortProfileFormat' [-Wimplicit-function-declaration]
> ../src/conf/domain_conf.c:5343: error: nested extern declaration of
> 'virVirtualPortProfileFormat' [-Wnested-externs]
>

The virVirtualPortProfileFormat just went below the
virVirtualPortProfileParamsParseXML function and got inside the
#ifndef PROXY block this way. But it doesn't belong there.

The attached patch moves virVirtualPortProfileFormat below the #ifndef
PROXY block.

Matthias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Fix-xen-proxy-build.diff
Type: text/x-diff
Size: 4123 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100526/f0390810/attachment-0001.bin>


More information about the libvir-list mailing list