[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: fix HTML errors in nwfilter docs



On 05/26/2010 02:44 AM, Daniel P. Berrange wrote:
>> * docs/formatnwfilter.html.in: Fix invalid HTML constructs.
>> Reported by Eduardo Otubo.
>> ---
>>
>> Don't know why a build on Fedora didn't catch these, so I
>> won't push until I get an ack that this fixes things on Ubuntu.
> 
> Are you missing the 'xhtml1-dtds' RPM on your machine ?

$ rpm -q xhtml1-dtds
xhtml1-dtds-1.0-20020801.5.noarch

But either that didn't catch it; or it did catch it but we have a bug in
the makefile that ignored the failure, such that I didn't notice it
scroll by.  Just to test things, I reverted to an older version, and
tried again; sure enough:

Generating formatnwfilter.html.tmp
formatnwfilter.html.in:390: HTML parser error : Unexpected end tag : p
    </p>
        ^
formatnwfilter.html.in:705: HTML parser error : Unexpected end tag : code
         <td>End of range of valid source ports</code></td>
                                                      ^
formatnwfilter.html.in:710: HTML parser error : Unexpected end tag : code
         <td>Start of range of valid destination ports</code></td>
                                                             ^

It's still the right thing to skip a test if xhtml1-dtds is not
installed, but it looks like we could improve the makefile to bail out
when we detect bad html.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]