[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add support for VirtualBox 3.2



On 05/26/2010 06:02 AM, Jean-Baptiste Rouault wrote:
> Hi there,
> 
> Here's a patch to add support to VirtualBox 3.2.
> +++ b/src/vbox/vbox_CAPI_v3_2.h
> @@ -0,0 +1,5607 @@
> +
> +/*
> + *  DO NOT EDIT! This is a generated file.
> + *
> + *  XPCOM IDL (XPIDL) definition for VirtualBox Main API (COM interfaces)
> + *  generated from XIDL (XML interface definition).
> + *
> + *  Source    : src/VBox/Main/idl/VirtualBox.xidl
> + *  Generator : src/VBox/Main/idl/xpcidl.xsl

Is this generator something that should be run as part of building
libvirt, or are we okay with checking in just the generated file?
Either way,

> +#ifndef ___VirtualBox_CXPCOM_h
> +#define ___VirtualBox_CXPCOM_h

Lines like this fail the cppi syntax-check.  Either we need to modify
cfg.mk to exempt this file from cppi checks, or you need to fix the
generation process to filter the file through cppi before committing it
into libvirt.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]