[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add support for VirtualBox 3.2



On 05/27/2010 02:21 PM, Matthias Bolte wrote:
>> Is this generator something that should be run as part of building
>> libvirt, or are we okay with checking in just the generated file?
> 
> He probably didn't generate the file. Those headers are part of the
> VirtualBox SDK. As the comment indicates they can also be generated
> from the VirtualBox.xidl file using a XSLT transformation.

How likely is this file to change?  And are those changes likely to be
manual edits or re-running a generator?

>> Lines like this fail the cppi syntax-check.  Either we need to modify
>> cfg.mk to exempt this file from cppi checks, or you need to fix the
>> generation process to filter the file through cppi before committing it
>> into libvirt.
>>
> 
> I just tried to make the vbox_CAPI_v3_2.h conform to cppi's checks,
> but the patch touches ~500 lines. Therefore, the less invasive fix
> would be to just ignore the vbox_CAPI_*.h headers for cppi checks.

You mean you tried this by hand?  Yeah, that would be painful.  Instead,
you can use cppi to touch those 500 lines in a completely automated way,
in less than a second (see commit 36d8e7d):

for f in vbox_CAPI_*.h; do cppi $f > $f.t && mv $f.t $f; done

At which point, if the header comment about being generated is
copy-and-paste and not indicative of how we will be maintaining the
file, I'd almost feel better reformatting the file than adding the
exemption (and maybe even adding a comment clarifying the 'this file is
generated' comment).

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]