[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: silence cppi warning, clarify vbox headers



On 05/27/2010 04:42 PM, Eric Blake wrote:
> These files are borrowed from upstream release versions, and should
> not need further edits in the context of libvirt (instead, a new
> upstream vbox release would entail adding a new header file).  We do
> not re-generate these files as part of libvirt, nor do we want to lose
> our minor edits (such as cppi cleanups).
> 
> * src/vbox/vbox_CAPI_v2_2.h: Clarify file origins.
> * src/vbox/vbox_CAPI_v3_0.h: Likewise.
> * src/vbox/vbox_CAPI_v3_1.h: Likewise.
> * src/vbox/vbox_CAPI_v3_2.h: Likewise.  Reindent with cppi.
> ---
> 
> I debated about pushing this as trivial, since it fixes a
> 'make syntax-check' failure, but decided the inserted comment
> may be worth an ack.

Good thing I didn't push yet.

> -
> +/*
> + * Libvirt notice: this file is drived from a particular VBOX snapshot,

s/drived/derived/

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]