[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: silence cppi warning, clarify vbox headers



2010/5/28 Eric Blake <eblake redhat com>:
> These files are borrowed from upstream release versions, and should
> not need further edits in the context of libvirt (instead, a new
> upstream vbox release would entail adding a new header file).  We do
> not re-generate these files as part of libvirt, nor do we want to lose
> our minor edits (such as cppi cleanups).
>
> * src/vbox/vbox_CAPI_v2_2.h: Clarify file origins.
> * src/vbox/vbox_CAPI_v3_0.h: Likewise.
> * src/vbox/vbox_CAPI_v3_1.h: Likewise.
> * src/vbox/vbox_CAPI_v3_2.h: Likewise.  Reindent with cppi.
> ---
>
> I debated about pushing this as trivial, since it fixes a
> 'make syntax-check' failure, but decided the inserted comment
> may be worth an ack.
>
>  src/vbox/vbox_CAPI_v2_2.h |    5 +-
>  src/vbox/vbox_CAPI_v3_0.h |    5 +-
>  src/vbox/vbox_CAPI_v3_1.h |    5 +-
>  src/vbox/vbox_CAPI_v3_2.h | 1055 +++++++++++++++++++++++----------------------
>  4 files changed, 541 insertions(+), 529 deletions(-)
>
> diff --git a/src/vbox/vbox_CAPI_v2_2.h b/src/vbox/vbox_CAPI_v2_2.h
> index 674b4e3..d82fe66 100644
> --- a/src/vbox/vbox_CAPI_v2_2.h
> +++ b/src/vbox/vbox_CAPI_v2_2.h
> @@ -1,4 +1,7 @@
> -
> +/*
> + * Libvirt notice: this file is drived from a particular VBOX snapshot,

s/drived/derived/

And I suggest s/a particular VBOX snapshot/the VirtualBox SDK/ because
'a particular VBOX snapshot' reads as if we grabbed these files from
some random SVN checkout or something like that.

> + * with libvirt edits; do not regenerate in the context of libvirt.
> + */
>  /*
>  *  DO NOT EDIT! This is a generated file.
>  *

ACK, with those comments addressed.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]