[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] another AUTHORS update



On 05/28/2010 03:33 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> Eduardo Otubo contacted me off-list, noticing that his name was not yet
>> in AUTHORS even though he has had commits in the past.  I've rectified
>> this situation with an obvious commit; not worth posting the diff to the
>> list (to avoid unnecessary exposure of all the email addresses...).
> 
> Here's a rule to help us automate the task of keeping
> our AUTHORS file in sync with the commit history:

Cool idea!

> 
> +# Give credit where due:
> +# Ensure that each commit author email address (possibly mapped via
> +# git log's .mailmap) appears in our AUTHORS file.
> +sc_check_author_list:
> +	@fail=0;							\
> +	for i in $$(git log --pretty=format:%aE%n|sort -u|grep -v '^$$'); do \
> +	  sanitized=$$(echo "$$i"|LC_ALL=C sed 's/\([^a-zA-Z0-9_ -]\)/\\\1/g'); \
> +	  grep -iq "<$$sanitized>" AUTHORS				\
> +	    || { printf '%s\n' "$$i" >&2; fail=1; };			\
> +	done;								\
> +	test $$fail = 1							\
> +	  && echo '$(ME): committer(s) not listed in AUTHORS' >&2;	\
> +	test $$fail = 0

ACK

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]