[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix libvirt-guests init script



> > +started() {
> > +    touch $VAR_SUBSYS_LIBVIRT_GUESTS
> 
> touch "$VAR_SUBSYS_LIBVIRT_GUESTS"
> 
> > +}
> > +
> >  start() {
> > -    [ -f $LISTFILE ] || return 0
> > +    [ -f $LISTFILE ] || { started; return 0; }
> 
> Do we want to detect failures in started (that is, failure to touch the
> lock file)?  Then again, failure to touch the lock file merely means
> that stop won't be called automatically, but doesn't affect whether we
> actually started and can call stop manually, so blindly succeeding seems
> okay to me.

Yeah, I think that's fine. Also no other init script seems to check it either.

> > +
> > +    rm -f $VAR_SUBSYS_LIBVIRT_GUESTS
> 
> rm -f "$VAR_SUBSYS_LIBVIRT_GUESTS"
> 
> ACK with those tweaks.

Thanks for the review. I made the corrections you suggested here and in the
next email and pushed.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]