[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/10] Implement QEMU/KVM support for SPICE graphics



On 11/01/2010 12:17 PM, Daniel P. Berrange wrote:
> This supports the -spice argument posted for review against
> the latest upstream QEMU/KVM. This supports the bare minimum
> config with port, TLS port & listen address. The x509 bits are
> added in a later patch.
> 
> * src/qemu_conf.c, src/qemu_conf.h: Add SPICE flag. Check for
>   -spice availability. Format -spice arg for command line
> * qemuhelptest.c: Add SPICE flag
> * qemuxml2argvdata/qemuxml2argv-graphics-spice.args: Add <graphics>
>   for spice
> * qemuxml2argvdata/qemuxml2argv-graphics-spice.xml: Add -spice arg
> * qemuxml2argvtest.c: Add SPICE flag
> ---
>  src/qemu/qemu_conf.c                               |   37 ++++++++++++++++++++
>  src/qemu/qemu_conf.h                               |    1 +
>  .../qemuxml2argv-graphics-spice.args               |    2 +-
>  .../qemuxml2argv-graphics-spice.xml                |    2 +
>  tests/qemuxml2argvtest.c                           |    2 +-
>  5 files changed, 42 insertions(+), 2 deletions(-)
> 
> +
> +        if (def->graphics[0]->data.spice.listenAddr)
> +            virBufferVSprintf(&opt, ",addr=%s", def->graphics[0]->data.spice.listenAddr);

This may be impacted if you take my comments in 3/10 about using
virSocketAddr.

Other than that, ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]