[libvirt] [PATCH 05/10] Implement QEMU/KVM support for SPICE graphics
Eric Blake
eblake at redhat.com
Tue Nov 2 22:49:35 UTC 2010
On 11/01/2010 12:17 PM, Daniel P. Berrange wrote:
> This supports the -spice argument posted for review against
> the latest upstream QEMU/KVM. This supports the bare minimum
> config with port, TLS port & listen address. The x509 bits are
> added in a later patch.
>
> * src/qemu_conf.c, src/qemu_conf.h: Add SPICE flag. Check for
> -spice availability. Format -spice arg for command line
> * qemuhelptest.c: Add SPICE flag
> * qemuxml2argvdata/qemuxml2argv-graphics-spice.args: Add <graphics>
> for spice
> * qemuxml2argvdata/qemuxml2argv-graphics-spice.xml: Add -spice arg
> * qemuxml2argvtest.c: Add SPICE flag
> ---
> src/qemu/qemu_conf.c | 37 ++++++++++++++++++++
> src/qemu/qemu_conf.h | 1 +
> .../qemuxml2argv-graphics-spice.args | 2 +-
> .../qemuxml2argv-graphics-spice.xml | 2 +
> tests/qemuxml2argvtest.c | 2 +-
> 5 files changed, 42 insertions(+), 2 deletions(-)
>
> +
> + if (def->graphics[0]->data.spice.listenAddr)
> + virBufferVSprintf(&opt, ",addr=%s", def->graphics[0]->data.spice.listenAddr);
This may be impacted if you take my comments in 3/10 about using
virSocketAddr.
Other than that, ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101102/36bc0da9/attachment-0001.sig>
More information about the libvir-list
mailing list