[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/10] Add SPICE support for QEMU driver configuration file



On 11/01/2010 12:17 PM, Daniel P. Berrange wrote:
> In common with VNC, the QEMU driver configuration file is used
> specify the host level TLS certificate location and a default
> password / listen address
> 
> * src/qemu/qemu.conf: Add spice_listen, spice_tls,
>   spice_tls_x509_cert_dir & spice_password config params
> * src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Parsing of
>   spice config parameters and updating -spice arg generation
>   to use them
> * tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-rhel6.args,
>   tests/qemuxml2argvtest.c: Expand test case to cover driver
>   level configuration
> ---
>  src/qemu/qemu.conf                                 |   40 +++++++++++++
>  src/qemu/qemu_conf.c                               |   62 +++++++++++++++++++-
>  src/qemu/qemu_conf.h                               |    4 +
>  src/qemu/qemu_driver.c                             |   15 ++++-
>  .../qemuxml2argv-graphics-spice.args               |    2 +-
>  tests/qemuxml2argvtest.c                           |    5 ++
>  6 files changed, 123 insertions(+), 5 deletions(-)
> 
> index 6cfbfe0..7df5794 100644
> --- a/src/qemu/qemu_conf.h
> +++ b/src/qemu/qemu_conf.h
> @@ -140,6 +140,10 @@ struct qemud_driver {
>      char *vncListen;
>      char *vncPassword;
>      char *vncSASLdir;
> +    unsigned int spiceTLS : 1;
> +    char *spiceTLSx509certdir;
> +    char *spiceListen;

Should this be virSocketAddr rather than a raw string?

Other than that, ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]