[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/10] Support SPICE channel security options



On 11/01/2010 12:17 PM, Daniel P. Berrange wrote:
> This extends the SPICE XML to allow channel security options
> 
>     <graphics type='spice' port='5901' tlsPort='-1' autoport='yes'>
>       <channel name='main' mode='secure'/>
>       <channel name='record' mode='insecure'/>
>     </graphics>
> 
> Any non-specified channel uses the default, which allows both
> secure & insecure usage
> 
> * src/conf/domain_conf.c, src/conf/domain_conf.h,
>   src/libvirt_private.syms: Add XML syntax for specifying per
>   channel security options for spice;.

s/;//

> * src/qemu/qemu_conf.c: Configure channel security with spice
> ---
>  docs/schemas/domain.rng                            |   21 ++++++
>  src/conf/domain_conf.c                             |   75 +++++++++++++++++++-
>  src/conf/domain_conf.h                             |   21 ++++++
>  src/libvirt_private.syms                           |    4 +
>  src/qemu/qemu_conf.c                               |   13 ++++
>  .../qemuxml2argv-graphics-spice.args               |    2 +-
>  .../qemuxml2argv-graphics-spice.xml                |    5 +-
>  7 files changed, 138 insertions(+), 3 deletions(-)

Again, we need something in docs/formatdomain.html.in.

> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -204,6 +204,10 @@ virDomainFindByName;
>  virDomainFindByUUID;
>  virDomainGetRootFilesystem;
>  virDomainGraphicsDefFree;
> +virDomainGraphicsSpiceChannelNameTypeFromString;
> +virDomainGraphicsSpiceChannelNameTypeToString;
> +virDomainGraphicsSpiceChannelModeTypeFromString;
> +virDomainGraphicsSpiceChannelModeTypeToString;

Swap lines to alphabetical order.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]