[libvirt] [PATCH 11/11] Wire up virDomainOpenConsole for LXC, Xen and UML

[Daniel P. Berrange]

On Wed, Nov 03, 2010 at 02:53:57PM +0100, Daniel Veillard wrote:
> On Tue, Nov 02, 2010 at 05:49:15PM +0000, Daniel P. Berrange wrote:
> > * src/lxc/lxc_driver.c, src/lxc/lxc_driver.c,
> >   src/xen/xen_driver.c: Wire up virDomainOpenConsole
> > ---
> >  src/lxc/lxc_driver.c |   67 ++++++++++++++++++++++++++++++++++++++++++-
> >  src/uml/uml_driver.c |   77 ++++++++++++++++++++++++++++++++++++++++++++++----
> >  src/xen/xen_driver.c |   59 +++++++++++++++++++++++++++++++++++++-
> >  3 files changed, 195 insertions(+), 8 deletions(-)
> > 
> [...]
> > +
> > +    if (chr->type != VIR_DOMAIN_CHR_TYPE_PTY) {
> > +        umlReportError(VIR_ERR_INTERNAL_ERROR,
> > +                        _("character device %s is not using a PTY"), devname);
> > +        goto cleanup;
> > +    }
> 
>   just wondering, why would that happen ?

With QEMU/UML you can configure virtual serial/console devices to be
exposed in host in many different ways, eg as a TCP socket. This code
only attempts to deal with devices setup with /dev/pts/NNN PTYs

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|