[libvirt] [PATCH] rpm: fix /var/lib/libvirt permissions

[Daniel P. Berrange]

On Wed, Nov 03, 2010 at 03:23:30PM -0600, Eric Blake wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=649511
> 
> Regression of forcing 0700 permissions (which breaks guest startup
> because the qemu user can't see /var/lib/libvirt/*.monitor) was
> introduced in commit 66823690e, as part of libvirt 0.8.2.
> 
> * libvirt.spec.in (%{_localstatedir}/lib/libvirt): Guarantee 755
> permissions.
> ---
> 
> Stumbled on this one today when upgrading from F13 to F14, and my
> VMs no longer started.  Turns out that the upgrade process
> reinitializes permissions according to the spec file, and the
> spec file has been wrong for a couple of releases now.
> 
>  libvirt.spec.in |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 869b5cc..827b8c5 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -801,7 +801,7 @@ fi
> 
>  %dir %{_localstatedir}/run/libvirt/
> 
> -%dir %{_localstatedir}/lib/libvirt/
> +%dir %attr(0755, root, root) %{_localstatedir}/lib/libvirt/

This should be completely deleted. It is a bug to list the
same path twice. Only the first installed RPM should have
it, in this case the libvirt-client

>  %dir %attr(0711, root, root) %{_localstatedir}/lib/libvirt/images/
>  %dir %attr(0711, root, root) %{_localstatedir}/lib/libvirt/boot/
>  %dir %attr(0700, root, root) %{_localstatedir}/cache/libvirt/
> @@ -895,7 +895,7 @@ fi
> 
>  %{_sysconfdir}/rc.d/init.d/libvirt-guests
>  %config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests
> -%dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt
> +%dir %attr(0755, root, root) %{_localstatedir}/lib/libvirt/

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|