[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] xen-proxy: Remove it entirely and use libvirtd instead



On 11/08/2010 10:35 AM, Matthias Bolte wrote:
> Suggested by danpb, as it's not up-to-date anymore and
> lacks many functions that were added to libvirtd.
> ---
>  Makefile.am                        |    2 +-
>  autobuild.sh                       |    3 +-
>  cfg.mk                             |    1 -
>  configure.ac                       |   26 +-
>  docs/uri.html.in                   |    3 +-
>  include/libvirt/virterror.h        |    2 +-
>  libvirt.spec.in                    |   14 +-
>  po/POTFILES.in                     |    1 -
>  proxy/.gitignore                   |    5 -
>  proxy/Makefile.am                  |   42 --
>  proxy/libvirt_proxy.c              |  856 -----------------------------
>  src/Makefile.am                    |    1 -
>  src/conf/cpu_conf.c                |    2 -
>  src/conf/cpu_conf.h                |    6 +-
>  src/conf/domain_conf.c             |   17 -
>  src/conf/domain_conf.h             |    2 -
>  src/conf/nwfilter_params.c         |    3 -
>  src/conf/storage_encryption_conf.c |    3 -
>  src/util/util.c                    |   67 ++--
>  src/xen/proxy_internal.c           | 1044 ------------------------------------
>  src/xen/proxy_internal.h           |  100 ----
>  src/xen/xen_driver.c               |   56 +--
>  src/xen/xen_driver.h               |   20 +-
>  src/xen/xen_hypervisor.c           |   34 +-
>  src/xen/xen_hypervisor.h           |    1 -
>  src/xen/xend_internal.c            |   56 +--
>  src/xen/xs_internal.c              |   78 +---
>  src/xen/xs_internal.h              |    3 -
>  28 files changed, 74 insertions(+), 2374 deletions(-)

Massive deletion, but looks sane and still compiles for me.  Agree with
danpb's assessment that libvirtd is a better option than the proxy these
days, and since we've already been defaulting to --without-proxy, this
doesn't impact the default.

ACK with one nit - I would squash this in to also ignore the proxy/
directory left behind on incremental updates.

diff --git i/.gitignore w/.gitignore
index b7eae66..fc3e9d5 100644
--- i/.gitignore
+++ w/.gitignore
@@ -14,6 +14,7 @@
 .sc-start-sc_*
 /GNUmakefile
 /libvirt-[0-9]*
+/proxy/
 /maint.mk
 ABOUT-NLS
 COPYING

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]