[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] schema: Move timer element inside clock



On 11/08/2010 04:31 AM, Jiri Denemark wrote:
> Both conf/domain_conf.c and domain XML documentation have <timer>
> elements inside /domain/clock. Change domain.rng schema to be consistent
> with them.
> ---
>  docs/schemas/domain.rng |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)

Conditional ACK: you also need to add at least one .xml file somewhere
under tests that uses a <timer> element, so that we can test that the
fixed .rng file validates our intended usage.  Right now:

$ git grep '<timer' tests

shows that we have no testsuite exposure of this element.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]