[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] show compiled in options in virsh --version



On Mon, Nov 08, 2010 at 08:26:18AM -0700, Eric Blake wrote:
> On 11/05/2010 11:20 AM, Daniel Veillard wrote:
> >   To ease debugging this trivial patch allows to find what was compiled
> > in in the local version of libvirt, this doesn't work for remote access
> > but that's probably sufficient. With the patch I get on my machine:
> > 
> > paphio:~/libvirt/tools -> ./virsh -V
> > Virsh command line tool of libvirt 0.8.4
> > See web site at http://libvirt.org/
> > 
> > Compiled with support for:
> >  Hypervisors: Xen QEmu/KVM UML OpenVZ LXC ESX PHYP Test
> >  Networking: Remote Daemon Network Bridging Netcf Nwfilter
> >  Storage: Dir Disk Filesystem SCSI Multipath iSCSI LVM
> >  Miscellaneous: SELinux Secrets Debug Readline
> > paphio:~/libvirt/tools ->
> 
> > 
> > +++ b/tools/virsh.c
> > @@ -11525,6 +11525,7 @@ vshUsage(void)
> >                        "    -t | --timing           print timing information\n"
> >                        "    -l | --log <file>       output logging to file\n"
> >                        "    -v | --version          program version\n\n"
> > +                      "    -V                      version and full options\n\n"
> 
> In general, it's nice to have a long-option to go with every short
> option, but I don't think it's worth holding up this patch for just that.
> 
> ACK.

  Thanks, pushed.

I really think that -V was the right pick since it's the usual flag for
this kind of informations, but since -v/--version was already used I had
no idea how to name the long option, especially starting with letter
v...

Daniel



-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]