[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix LXC container console device setup



On Wed, Nov 10, 2010 at 01:30:07PM +0000, Daniel P. Berrange wrote:
> From: Daniel P. Berrange <dan berrange com>
> 
> The /dev/console device inside the container must NOT map
> to the real /dev/console device node, since this allows the
> container control over the current host console. A fun side
> effect of this is that starting a container containing a
> real Fedora OS will kill off your X server.

  haha, that's the reason :-)

> Remove the /dev/console node, and replace it with a symlink
> to the primary console TTY
> 
> * src/lxc/lxc_container.c: Replace /dev/console with a
>   symlink to /dev/pty/0
> * src/lxc/lxc_controller.c: Remove /dev/console from cgroups
>   ACL
> ---
>  src/lxc/lxc_container.c  |    6 +++++-
>  src/lxc/lxc_controller.c |    1 -
>  2 files changed, 5 insertions(+), 2 deletions(-)

  Looks fine to me, ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]