[libvirt] [PATCH 3/3] Do a better job of validating IP and MAC addresses in network.rng

Eric Blake eblake at redhat.com
Thu Nov 11 21:05:37 UTC 2010


On 11/11/2010 01:41 PM, Laine Stump wrote:
> +  <!-- An ipv4 "dotted quad" address -->
> +  <define name='ipv4-addr'>
> +    <data type='string'>
> +      <param name="pattern">(((25[0-5])|(1[0-9]{2})|(2[0-4][0-9])|([0-9]{1,2}))\.){3}((25[0-5])|(1[0-9]{2})|(2[0-4][0-9])|([0-9]{1,2}))</param>

This allows 01.1.1.1 (leading zero looks unusual in an IPv4 address).  I
would have done something like:

(((25[0-5])|(2[0-4][0-9])|(1[0-9][0-9])|([1-9][0-9])|[0-9])\.){3}...

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101111/d481ba9a/attachment-0001.sig>


More information about the libvir-list mailing list