[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Do a better job of validating IP and MAC addresses in network.rng



On 11/11/2010 05:07 PM, Eric Blake wrote:
On 11/11/2010 02:57 PM, Laine Stump wrote:
name="pattern">(((25[0-5])|(1[0-9]{2})|(2[0-4][0-9])|([0-9]{1,2}))\.){3}((25[0-5])|(1[0-9]{2})|(2[0-4][0-9])|([0-9]{1,2}))</param>

This allows 01.1.1.1 (leading zero looks unusual in an IPv4 address).  I
would have done something like:

How about if I squash in the attached delta-diff?
Works for me.

ACK.

Okay. I pushed the original patch with the delta squashed in (after verifying make check still passes).

Thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]