[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] phyp: Don't do a flags check in the storage driver



On Fri, Nov 12, 2010 at 02:03:34PM +0100, Matthias Bolte wrote:
> This makes the storage driver fail when the connection is
> opened with the VIR_CONNECT_RO flag, resulting in a read-only
> connection with no storage driver.
> ---
>  src/phyp/phyp_driver.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
> index a685bd1..4c723a2 100644
> --- a/src/phyp/phyp_driver.c
> +++ b/src/phyp/phyp_driver.c
> @@ -3927,10 +3927,8 @@ phypDomainSetCPU(virDomainPtr dom, unsigned int nvcpus)
>  static virDrvOpenStatus
>  phypVIOSDriverOpen(virConnectPtr conn,
>                     virConnectAuthPtr auth ATTRIBUTE_UNUSED,
> -                   int flags)
> +                   int flags ATTRIBUTE_UNUSED)
>  {
> -    virCheckFlags(0, VIR_DRV_OPEN_ERROR);
> -
>      if (conn->driver->no != VIR_DRV_PHYP)
>          return VIR_DRV_OPEN_DECLINED;
>  

ACK

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]