[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/11] Refactor iSCSI driver code to facilitate future changes



On Fri, Nov 12, 2010 at 12:39:57PM -0500, Dave Allan wrote:
> On Fri, Nov 12, 2010 at 04:22:35PM +0000, Daniel P. Berrange wrote:
> > The following series of patches are adding significant
> > extra functionality to the iSCSI driver. THe current
> > internal helper methods are not sufficiently flexible
> > to cope with these changes. This patch refactors the
> > code to avoid needing to have a virStoragePoolObjPtr
> > instance as a parameter, instead passing individual
> > target, portal and initiatoriqn parameters.
> 
> What's your motivation for removing the struct and passing the
> parameters individually?  It's clearly not wrong, but why generate the
> code churn if it's not required?

The storage pool discovery code in a following patch does
not have any virStoragePoolObjPtr available, since its
very purpose is to discover one !

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]