[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Generate HACKING from docs/hacking.html.in



2010/11/12 Eric Blake <eblake redhat com>:
> On 11/12/2010 10:15 AM, Matthias Bolte wrote:
>> 2010/11/11 Eric Blake <eblake redhat com>:
>>> On 11/11/2010 01:39 PM, Matthias Bolte wrote:
>>>> Tweak pre tags in docs/hacking.html.in to achieve proper
>>>> indentation of their plaintext representation.
>>>>
>>>> Also use more b/i/code tags in docs/hacking.html.in.
>>>> ---
>>>>  HACKING              |  602 +++++++++++++++++++++++++++++---------------------
>>>
>> I also tested it in a VPATH build and it works as it should.
>>
>> v2 is attached.
>
> Patch 2 review:
>
>> +++ b/Makefile.am
>> @@ -56,6 +56,15 @@ NEWS: $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.in
>>          | perl -pe 's/[ \t]+$$//'                            \
>>          > $ -t && mv $ -t $@ ; fi );
>>
>> +syntax-check: $(top_srcdir)/HACKING
>
> Move this line into cfg.mk.  Since 'make syntax-check' can only
> activated if you use GNU make (because it is only specified in
> maint.mk), we should hide any dependencies added to it inside our
> customization of maint.mk, rather than putting it directly in Makefile.am.
>
>> +
>> +$(top_srcdir)/HACKING: $(top_srcdir)/docs/hacking1.xsl $(top_srcdir)/docs/hacking2.xsl \
>> +                       $(top_srcdir)/docs/wrapstring.xsl $(top_srcdir)/docs/hacking.html.in
>> +     -@(if [ -x $(XSLTPROC) ] ; then \
>> +        $(XSLTPROC) --nonet $(top_srcdir)/docs/hacking1.xsl $(top_srcdir)/docs/hacking.html.in | \
>> +        $(XSLTPROC) --nonet $(top_srcdir)/docs/hacking2.xsl - \
>> +        | perl -0777 -pe 's/\n\n+$$/\n/' \
>> +        > $ -t && mv $ -t $@ ; fi );
>
> However, keep this line in Makefile.am; it may be useful to
> independently run 'make HACKING', even if you aren't a maintainer.
>
> I'm trusting you on the rest (that, and I was able to apply this, rerun
> 'make HACKING', and see no difference).  And you've cleaned up a few
> things from v1 (such as no trailing blank line in HACKING).
>
> ACK once you move the one line, and thanks for taking this on!
>

Okay, I folded in your comments on both patches and pushed the result.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]