[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: add command net-info



于 2010年11月12日 19:34, Justin Clift 写道:
On 11/08/2010 07:40 PM, Osier Yang wrote:
<snip>
+    {"desc", "Returns basic information about the network"},

Probably better to make it clear that it's about a "virtual
network", rather than any other kind of network.

Maybe "Returns basic information about a virtual network"?
(or something similar)

I think "network" here is fine, because libvirt use term "network"
all over the project, it has specific meaning for libvirt.  :)



<snip>
@@ -9924,6 +9982,7 @@ static const vshCmdDef commands[] = {
      {"net-start", cmdNetworkStart, opts_network_start, info_network_start},
      {"net-undefine", cmdNetworkUndefine, opts_network_undefine, info_network_undefine},
      {"net-uuid", cmdNetworkUuid, opts_network_uuid, info_network_uuid},
+    {"net-info", cmdNetworkInfo, opts_network_info, info_network_info},

Instead of adding net-info to the end of the net-* commands, it's
probably better to have it positioned alphabetically like the others.
(between net-edit and net-list seems like the right place)

With those two nits fixed, ACK. :)

good point, will update.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]