[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr



On 10/29/2010 05:52 AM, Daniel P. Berrange wrote:
> The virConnectPtr struct will cache instances of all other
> objects. APIs like virDomainLookupByUUID will return a
> cached object, so if you do virDomainLookupByUUID twice in
> a row, you'll get the same exact virDomainPtr instance.

Dave already ACK'd the design without looking through the code.

> 
> * src/datatypes.h: Delete all hash tables.
> * src/datatypes.c: Remove all object caching code
> ---
>  src/datatypes.c |  657
+++++++++++++------------------------------------------
>  src/datatypes.h |   10 -
>  2 files changed, 149 insertions(+), 518 deletions(-)

I looked through this, and didn't see any obvious mistakes in the
deletion process, so:

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]