[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] replace last instances of close()



On Tue, Nov 16, 2010 at 09:58:21PM -0500, Stefan Berger wrote:
> v2:
>   - added comments about the monitor lock being used to protect the 
> file descriptor 'fd'
>   - eofcb is not set anywhere, so also removing it; the if statement 
> checking on it seems dead code
> 
> I am replacing the last instances of close() I found with VIR_CLOSE() / 
> VIR_FORCE_CLOSE respectively.
> 
> The first part patches virsh, which I missed out on previously.
> 
> The 2nd patch I had left out intentionally to look at it more carefully:
> The 'closed' variable could be easily removed since it wasn't used 
> anywhere else. The possible race condition that could result from the 
> filedescriptor being closed and not set to -1 (and possibly let us write 
> into 'something' totally different if the fd was allocated by another 
> thread) seems to be prevented by the qemuMonitorLock() already placed 
> around the code that reads from or writes to the fd. So the change of 
> this code as shown in the patch should not have any side-effects.
> 
> Signed-off-by: Stefan Berger<stefanb us ibm com>

ACK


Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]